Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade ESLint #11716

Merged
merged 7 commits into from
Jan 23, 2025
Merged

Upgrade ESLint #11716

merged 7 commits into from
Jan 23, 2025

Conversation

agatemosu
Copy link
Contributor

No description provided.

nanaya
nanaya reviewed Dec 5, 2024
View reviewed changes
Copy link
Collaborator

@nanaya nanaya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not a yes or no but I don't mind just dropping all the eslint custom styling and go with whatever prettier spits out (yes, including the double quotes)

@agatemosu
Copy link
Contributor Author

agatemosu commented Dec 6, 2024 •
edited
Loading

not a yes or no but I don't mind just dropping all the eslint custom styling and go with whatever prettier spits out (yes, including the double quotes)

Prettier also has the singleQuote and jsxSingleQuote settings. It also supports the quote_type = single setting in the EditorConfig. Could one of those be used?

@agatemosu
Copy link
Contributor Author

agatemosu commented Dec 13, 2024 •
edited
Loading

I did another branch using prettier: https://github.com/agatemosu/osu-web/commits/prettier

@notbakaneko notbakaneko self-requested a review January 22, 2025 09:58
@notbakaneko notbakaneko enabled auto-merge January 23, 2025 08:00
notbakaneko
notbakaneko approved these changes Jan 23, 2025
View reviewed changes
Copy link
Collaborator

@notbakaneko notbakaneko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll do the upgrade to 9 later.

I (or rather, yarn did) fixed and pushed the lockfile conflicts

@notbakaneko notbakaneko merged commit 83e7f98 into ppy:master Jan 23, 2025
3 checks passed
@agatemosu agatemosu deleted the eslint branch January 23, 2025 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nanaya nanaya nanaya left review comments

@notbakaneko notbakaneko notbakaneko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@agatemosu @nanaya @notbakaneko